Fix silent serialization failure when publishing non-JSON-serializable objects #229
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
jguz-pubnub
commented
Feb 9, 2026
Comment on lines
+33
to
+43
| except TypeError as e: | ||
| exc = PubNubException( | ||
| errormsg=str(e), | ||
| pn_error=PNERR_JSON_NOT_SERIALIZABLE | ||
| ) | ||
| status = PNStatus() | ||
| status.category = PNStatusCategory.PNSerializationErrorCategory | ||
| status.error = True | ||
| status.error_data = PNErrorData(str(exc), exc) | ||
| exc.status = status | ||
| raise exc |
Contributor
Author
There was a problem hiding this comment.
The error structure has a circular reference, PubNubException.status.error_data.exception points back to the same PubNubException. This PR implements a fix that works within the current model to prevent regressions, but the error hierarchy would benefit from being revisited in the future
Member
There was a problem hiding this comment.
Nice! Good find and fast fix thank you 🎉
There was a problem hiding this comment.
Thanks for the quick fix, I reported this to @stephenlb first at 2:48am IST and less than 24hrs it's fixed!
This was discovered by using a custom agent creating a tool on the fly in remote VPSs instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.